Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gateway): add MeshGateway support to MeshAccessLog #5101

Merged
merged 3 commits into from
Oct 7, 2022
Merged

feat(gateway): add MeshGateway support to MeshAccessLog #5101

merged 3 commits into from
Oct 7, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Oct 5, 2022 •
edited
Loading

Checklist prior to review

> Changelog: skip

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? -- MeshAccessLog implementation #4979
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests -- none
  • Manual Kubernetes Tests -- none
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner October 5, 2022 14:23
@michaelbeaumont michaelbeaumont mentioned this pull request Oct 5, 2022
Closed
1 task
@michaelbeaumont michaelbeaumont mentioned this pull request Oct 6, 2022
Merged
12 tasks
@michaelbeaumont
Copy link
Contributor Author

@jakubdyszkiewicz gonna merge this, let me know if there's anything missing in the e2e test.

@michaelbeaumont michaelbeaumont merged commit 6999678 into kumahq:master Oct 7, 2022
@michaelbeaumont michaelbeaumont deleted the feat/log_gateway branch October 7, 2022 16:27
@lukidzi lukidzi changed the title feat: add MeshGateway support to MeshAccessLog feat(gateway): add MeshGateway support to MeshAccessLog Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @jakubdyszkiewicz