chore(*) encapsulate proxy init container #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
force-pushed
the
chore/encapsulate-proxy-init
branch
from
e7c5f8a to
b9d00e5
Compare
yskopets
reviewed
Dec 16, 2019
| @@ -224,8 +224,7 @@ Flags: | |||
| --control-plane-service-name string Service name of the Kuma Control Plane (default "kuma-control-plane") | |||
| --control-plane-version string version shared by all components of the Kuma Control Plane (default "latest") | |||
| --dataplane-image string image of the Kuma Dataplane component (default "kong-docker-kuma-docker.bintray.io/kuma-dp") | |||
| --dataplane-init-image string init image of the Kuma Dataplane component (default "docker.io/istio/proxy_init") | |||
| --dataplane-init-version string version of the init image of the Kuma Dataplane component (default "1.1.2") | |||
There was a problem hiding this comment.
Let's document this as a backwards-incompatible change (removal of --dataplane-init-version option)
jakubdyszkiewicz
force-pushed
the
chore/encapsulate-proxy-init
branch
from
b9d00e5 to
b9f6979
Compare
yskopets
reviewed
Dec 17, 2019
yskopets
approved these changes
Dec 19, 2019
jakubdyszkiewicz
force-pushed
the
chore/encapsulate-proxy-init
branch
from
0997e81 to
0521abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Encapsulate proxy init container