Provided CA via kumactl #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
reviewed
Dec 10, 2019
jakubdyszkiewicz
force-pushed
the
feature/provided-ca-kumactl
branch
from
98f6332 to
fcd7703
Compare
jakubdyszkiewicz
changed the base branch from
feature/provided-ca-server
to
master
|
Introduced admin in catalog and removed hardcode from kumactl. For now dataplaneToken api is still in catalog, so it's not incompatibile. Removing it would require to change kumactl and kuma-dp to check if dataplane token ws is on. This will come in a separate PR, but it's not required for 0.3.0 release |
yskopets
reviewed
Dec 12, 2019
yskopets
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provided CA via kumactl
Since there is no config for port, it is hardcoded for now.