-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gateway): configure overload_manager based on max memory #4694
feat(gateway): configure overload_manager based on max memory #4694
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4694 +/- ##
==========================================
+ Coverage 46.43% 46.45% +0.01%
==========================================
Files 687 687
Lines 46702 46788 +86
==========================================
+ Hits 21688 21736 +48
- Misses 23094 23128 +34
- Partials 1920 1924 +4
Continue to review full report at Codecov.
|
9a4adcc
to
1a5c60b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the approach SGTM. Would it make sense to also add this for all DPPs in the system? Not only for gateway
Ok, I see that was answered in another conversation. |
a74b4ef
to
da9c0e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
da9c0e0
to
c0d14a0
Compare
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
c0d14a0
to
1f58672
Compare
Summary
As suggested by the Envoy docs
This PR checks both Kubernetes limits (via Downward API) directly as well as
cgroup
limits if they're available.Checklist prior to review
MeshGateway
kuma-website#931UPGRADE.md
? --