Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): configure overload_manager based on max memory #4694

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jul 28, 2022

Summary

As suggested by the Envoy docs

This PR checks both Kubernetes limits (via Downward API) directly as well as cgroup limits if they're available.

Checklist prior to review

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #4694 (1f58672) into master (3926791) will increase coverage by 0.01%.
The diff coverage is 59.30%.

@@            Coverage Diff             @@
##           master    #4694      +/-   ##
==========================================
+ Coverage   46.43%   46.45%   +0.01%     
==========================================
  Files         687      687              
  Lines       46702    46788      +86     
==========================================
+ Hits        21688    21736      +48     
- Misses      23094    23128      +34     
- Partials     1920     1924       +4     
Impacted Files Coverage Δ
pkg/config/app/kuma-dp/config.go 60.86% <ø> (ø)
...ime/k8s/controllers/gateway_instance_controller.go 0.00% <0.00%> (ø)
...pp/kuma-dp/pkg/dataplane/envoy/remote_bootstrap.go 58.16% <37.14%> (-6.24%) ⬇️
pkg/xds/bootstrap/template_v3.go 96.03% <94.59%> (-0.17%) ⬇️
pkg/xds/bootstrap/generator.go 61.06% <100.00%> (+0.48%) ⬆️
pkg/api-server/server.go 74.68% <0.00%> (-2.08%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 89.77% <0.00%> (-1.14%) ⬇️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (ø)
pkg/xds/cache/once/once.go 100.00% <0.00%> (+5.00%) ⬆️
pkg/xds/cache/once/cache.go 87.17% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3926791...1f58672. Read the comment docs.

Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the approach SGTM. Would it make sense to also add this for all DPPs in the system? Not only for gateway

app/kuma-dp/pkg/dataplane/envoy/remote_bootstrap.go Outdated Show resolved Hide resolved
app/kuma-dp/pkg/dataplane/envoy/remote_bootstrap.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz
Copy link
Contributor

Would it make sense to also add this for all DPPs in the system? Not only for gateway

Ok, I see that was answered in another conversation.

@michaelbeaumont michaelbeaumont force-pushed the feat/overload_manager branch 2 times, most recently from a74b4ef to da9c0e0 Compare August 1, 2022 09:06
@michaelbeaumont michaelbeaumont marked this pull request as ready for review August 1, 2022 09:29
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner August 1, 2022 09:29
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@michaelbeaumont michaelbeaumont enabled auto-merge (squash) August 1, 2022 11:51
@michaelbeaumont michaelbeaumont linked an issue Aug 1, 2022 that may be closed by this pull request
1 task
@michaelbeaumont michaelbeaumont merged commit 165df75 into kumahq:master Aug 1, 2022
@michaelbeaumont michaelbeaumont deleted the feat/overload_manager branch August 1, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure the overload manager for Gateway dataplanes
4 participants