fix(gateway): use MeshGatewayInstance mesh annotation when matching #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Beaumont <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4361 +/- ##
=======================================
Coverage 55.41% 55.41%
=======================================
Files 941 941
Lines 57125 57129 +4
=======================================
+ Hits 31654 31659 +5
- Misses 22964 22965 +1
+ Partials 2507 2505 -2
Continue to review full report at Codecov.
|
|
I think annotation makes more sense as this is a workload. |
lahabana
approved these changes
May 27, 2022
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2022
…4361) Signed-off-by: Mike Beaumont <[email protected]> (cherry picked from commit d08a53a)
mergify bot
added a commit
that referenced
this pull request
May 27, 2022
…backport #4361) (#4371) fix(gateway): use MeshGatewayInstance mesh annotation when matching (#4361) Signed-off-by: Mike Beaumont <[email protected]> (cherry picked from commit d08a53a) Co-authored-by: Mike Beaumont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Or should
MeshGatewayInstancehave a.meshfield likeMeshGateway/MeshGatewayRoute?Since it's namespaced though, it will need to respect the Namespace annotation either way.