-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*): remove flag '--experimental-meshgateway' #4315
Conversation
Signed-off-by: Ilya Lobkov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4315 +/- ##
==========================================
- Coverage 55.41% 55.41% -0.01%
==========================================
Files 941 941
Lines 57074 57063 -11
==========================================
- Hits 31630 31621 -9
+ Misses 22938 22935 -3
- Partials 2506 2507 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things missing here with helm.sh
and MeshGatewayConfig
, I'm taking a look
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
0ce5c41
to
4568da9
Compare
Signed-off-by: Ilya Lobkov <[email protected]> # Conflicts: # app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.global.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.override-env-vars.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.with-egress.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml # app/kumactl/cmd/install/testdata/install-control-plane.with-helm-values.yaml # app/kumactl/cmd/install/testdata/install-control-plane.with-ingress.golden.yaml # app/kumactl/cmd/install/testdata/install-control-plane.zone.golden.yaml
Signed-off-by: Ilya Lobkov <[email protected]>
Maybe @jakubdyszkiewicz can take another look at my changes |
Summary
Remove flag
--experimental-meshgateway
Full changelog
Issues resolved
Fix #4263
Documentation
Testing
Backwards compatibility
UPGRADE.md
with any steps users will need to take when upgrading.backport-to-stable
label if the code follows our backporting policy