GUI server config #428
Merged
GUI server config #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
reviewed
Nov 13, 2019
pkg/gui/gui_config.go
Outdated
| func FromServerConfig(config gui_server.GuiConfig) GuiConfig { | ||
| return GuiConfig{ | ||
| ApiUrl: config.ApiUrl, | ||
| Environment: config.Environment, |
There was a problem hiding this comment.
Similarly to the earlier comment, why do we configure Environment separately leaving a room for a contradiction between ApiUrl and Environment ?
pkg/gui/gui_config.go
Outdated
| Environment string `json:"environment"` | ||
| } | ||
|
|
||
| func FromServerConfig(config gui_server.GuiConfig) GuiConfig { |
There was a problem hiding this comment.
Let's keep FromServerConfig() func in a package other than types/ (e.g., in server/ rather than server/types/)
Motivation: to make it clear that REST API doesn't depend on config types
jakubdyszkiewicz
force-pushed
the
feature/static-server
branch
from
0715baf to
494a565
Compare
jakubdyszkiewicz
force-pushed
the
feature/gui-server-config
branch
from
cbd92eb to
97154b8
Compare
jakubdyszkiewicz
changed the base branch from
feature/static-server
to
master
yskopets
approved these changes
Nov 14, 2019
| writer.WriteHeader(500) | ||
| return | ||
| } | ||
| if _, err := writer.Write(bytes); err != nil { |
There was a problem hiding this comment.
Let's set Content-Type: application/json
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The problem is that even if we expose the GUI on some port, the API is on a different one. We need to deliver configuration about API coordinates. To do this, we can expose
/configendpoint with configuration.I used similar pattern to Catalog for now, which is keep it as Kuma Config, but don't expose env vars/yaml. Autoconfig everything.
Once we get more options for frontend, we can put it in the
GuiConfigand use standard way to configure Kuma CP to configure embedded frontend.Also I exposed the environment variable, to display if kuma is running on k8s or not on the GUI.