fix(docs): improve developer docs #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo in e2e test tips link inside `DEVELOPER.md` file Signed-off-by: Pouriya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4227 +/- ##
=======================================
Coverage 55.64% 55.65%
=======================================
Files 933 933
Lines 56251 56251
=======================================
+ Hits 31301 31304 +3
+ Misses 22462 22460 -2
+ Partials 2488 2487 -1
Continue to review full report at Codecov.
|
pouriyajamshidi
changed the title
pouriyajamshidi
changed the title
add unzip to the CLI section and fix typo in e2e test tips link Signed-off-by: Pouriya <[email protected]>
pouriyajamshidi
force-pushed
the
fix/typo_in_developer_readme
branch
from
131cfcc
to
e9a661f
Compare
michaelbeaumont
approved these changes
May 2, 2022
|
Thx for the contrib! |
parkanzky
pushed a commit
that referenced
this pull request
May 6, 2022
- fix typo in e2e test tips link inside `DEVELOPER.md` file - add unzip to the CLI section and fix typo in e2e test tips link Signed-off-by: Pouriya <[email protected]> Signed-off-by: Paul Parkanzky <[email protected]>
lukidzi
pushed a commit
that referenced
this pull request
May 11, 2022
- fix typo in e2e test tips link inside `DEVELOPER.md` file - add unzip to the CLI section and fix typo in e2e test tips link Signed-off-by: Pouriya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix typo in e2e test tips link inside
DEVELOPER.mdfile and addunzipin the list of CLI tools sectionFull changelog
DEVELOPER.mdfileunzipto the command line tool section ofDEVELOPER.mdto preventmake dev/toolscommand failure if the system does not haveunzipinstalledSigned-off-by: Pouriya [email protected]