Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): support protoc download for darwin arm #4200

Closed
wants to merge 1 commit into from

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Apr 19, 2022

Summary

uname -m for darwin return arm64 while for linux aarch64. Added if condition to set proper version for protoc and helm-docs

Full changelog

  • [added condition to support darwin]

Issues resolved

Part of #237

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

@lukidzi lukidzi requested a review from a team as a code owner April 19, 2022 17:15
@lukidzi lukidzi closed this Apr 19, 2022
@lukidzi lukidzi deleted the feat/protoc_darwin branch May 11, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant