fix(kuma-cp): don't run dataplane gc in global #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahabana
changed the title
We were running the GC in global when we should only delete dataplanes in zones. We also moved all the conditions for setting up components inside the Setup methods to make things easier to read Fix kumahq#2015 Signed-off-by: Charly Molter <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4184 +/- ##
==========================================
+ Coverage 55.85% 55.88% +0.03%
==========================================
Files 930 930
Lines 56429 56420 -9
==========================================
+ Hits 31516 31528 +12
+ Misses 22401 22373 -28
- Partials 2512 2519 +7
Continue to review full report at Codecov.
|
jakubdyszkiewicz
approved these changes
Apr 15, 2022
SallyBlichWalkMe
pushed a commit
to SallyBlichWalkMe/kuma
that referenced
this pull request
Apr 21, 2022
We were running the GC in global when we should only delete dataplanes in zones. We also moved all the conditions for setting up components inside the Setup methods to make things easier to read Fix kumahq#2015 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Sally Blich <[email protected]>
lukidzi
pushed a commit
that referenced
this pull request
May 11, 2022
We were running the GC in global when we should only delete dataplanes in zones. We also moved all the conditions for setting up components inside the Setup methods to make things easier to read Fix #2015 Signed-off-by: Charly Molter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were running the GC in global when we should only delete dataplanes in zones.
We also moved all the conditions for setting up components inside the Setup methods to make things
easier to read.
In the future I'd like to move all the setup methods in
app/kuma-cp/cmdthis would avoid each package to depend on runtime also setting up the runtime has nothing to do with what the original packages do anywayFull changelog
runtimebut directly on the map it needs.Issues resolved
Fix #2015