feat(*) validate token requirement #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
force-pushed
the
feature/kuma-dp-validate-token-server
branch
from
78e238d to
2864227
Compare
yskopets
reviewed
Nov 11, 2019
app/kumactl/pkg/cmd/root_context.go
Outdated
| @@ -134,6 +134,9 @@ func (rc *RootContext) CurrentDataplaneTokenClient() (tokens.DataplaneTokenClien | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| if !components.Apis.DataplaneToken.Enabled() { | |||
| return nil, errors.New("Dataplane Token Server in Kuma CP is disabled. Either enable the server or run Kuma DP without token.") | |||
There was a problem hiding this comment.
or run Kuma DP without token
Why is this message about Kuma DP ? It's app/kumactl/pkg/cmd/root_context.go
There was a problem hiding this comment.
When dataplane token server is disabled user can either enable the server to generate token or just run kuma dp without token. Do you think we skip the running kuma dp without token option?
| Expect(err).To(HaveOccurred()) | ||
|
|
||
| // and | ||
| Expect(buf.String()).To(Equal("Error: failed to create dataplane token client: Dataplane Token Server in Kuma CP is disabled. Either enable the server or run Kuma DP without token.\n")) |
There was a problem hiding this comment.
or run Kuma DP without token
Why is this message about Kuma DP ? It's app/kumactl/cmd/generate/generate_dataplane_token_test.go
yskopets
approved these changes
Nov 11, 2019
jakubdyszkiewicz
force-pushed
the
feature/kuma-dp-use-catalogue
branch
from
3ef6e7a to
d711881
Compare
jakubdyszkiewicz
force-pushed
the
feature/kuma-dp-validate-token-server
branch
from
2864227 to
b55c527
Compare
jakubdyszkiewicz
changed the base branch from
feature/kuma-dp-use-catalogue
to
master
yskopets
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary