feat(*) use catalogue in dp #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
approved these changes
Nov 11, 2019
jakubdyszkiewicz
force-pushed
the
feature/dataplane-token-server-improvements
branch
from
6862424 to
077f7de
Compare
jakubdyszkiewicz
force-pushed
the
feature/kuma-dp-use-catalogue
branch
from
3ef6e7a to
d711881
Compare
jakubdyszkiewicz
changed the base branch from
feature/dataplane-token-server-improvements
to
master
|
Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It had to be done to have access to catalog in kuma-dp.
It is breaking change since now we have to provide API Server address to kuma-dp. On K8S this is abstracted from the user by injector so this is not a problem. On Universal we probably need to add instructions to our release notes.
Issues resolved
Fix #314