Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuma-api: add protobuf descriptor for TrafficRoute type #396

Merged
merged 1 commit into from
Nov 5, 2019
Merged

kuma-api: add protobuf descriptor for TrafficRoute type #396

merged 1 commit into from
Nov 5, 2019

Conversation

yskopets
Copy link
Contributor

Summary

  • add protobuf descriptor for TrafficRoute type
  • add validators
  • add unit tests for validators

@yskopets yskopets added this to the 0.3.0 milestone Oct 30, 2019
@yskopets yskopets force-pushed the feature/traffic-route-proto branch from b148178 to 12affbe Compare October 30, 2019 12:17
@yskopets yskopets force-pushed the feature/traffic-route-proto branch from 12affbe to d8352c1 Compare October 30, 2019 13:10
jakubdyszkiewicz
jakubdyszkiewicz reviewed Oct 31, 2019
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so should we just put as many validators as possible in protobuff itself? Because we haven't done this with any other resource.
Does it make sense if we considering resigning from protobuff?

@yskopets
Copy link
Contributor Author

yskopets commented Nov 4, 2019 •
edited
Loading

We use protobuf at least as a schema descriptor.

So, until we replace it, we should use all its capabilities.

@yskopets yskopets merged commit b39e6a1 into master Nov 5, 2019
@yskopets yskopets deleted the feature/traffic-route-proto branch December 19, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees

@jakubdyszkiewicz jakubdyszkiewicz

Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yskopets @jakubdyszkiewicz