Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] kuma-ctl: adds get traffic-logs name.namespace #344

Closed

Conversation

michal-franc
Copy link

@michal-franc michal-franc commented Oct 15, 2019

[WIP]

Summary

This is still a work in progress.

Full changelog

TODO:

  • traffic-log
  • test on k8s backend
  • DataplaneInsight
  • Dataplane
  • Mesh
  • ProxyTemplate
  • TrafficPermission

@michal-franc michal-franc changed the title [WIP] kuma-ctl: adds get traffic-logs <name>.namespace [WIP] kuma-ctl: adds get traffic-logs name.namespace Oct 15, 2019
@@ -0,0 +1,32 @@
{
"items": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output of kumactl get <type> <name> should be a single object rather than a list

@@ -0,0 +1,15 @@
items:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output of kumactl get <type> <name> should be a single object rather than a list

app/kumactl/cmd/get/arg_regex_validation.go Show resolved Hide resolved
app/kumactl/cmd/get/get_traffic_logs.go Show resolved Hide resolved
app/kumactl/cmd/get/get_traffic_logs.go Show resolved Hide resolved
app/kumactl/cmd/get/get_traffic_logs.go Show resolved Hide resolved

args := append([]string{
"--config-file", filepath.Join("..", "testdata", "sample-kumactl.config.yaml"),
"get", "traffic-logs", "web2-to-backend2.namespace2"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test case for kubernetes environment (because of web2-to-backend2.namespace2).

We also need a test case for universal environment (i.e. web2-to-backend2)

@subnetmarco
Copy link
Contributor

Checking in to see if you were able to make any progress on this PR @michal-franc

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tharun208
Copy link
Contributor

Hi @yskopets @michal-franc Can I start working on this?

@michal-franc
Copy link
Author

@tharun208 feel free to revive it but @jakubdyszkiewicz might be best person to ask about this task now

@jakubdyszkiewicz
Copy link
Contributor

Done in https://github.com/Kong/kuma/pull/667

Thanks @michal-franc for creating a starting point for @tharun208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants