-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] kuma-ctl: adds get traffic-logs name.namespace #344
[WIP] kuma-ctl: adds get traffic-logs name.namespace #344
Conversation
@@ -0,0 +1,32 @@ | |||
{ | |||
"items": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output of kumactl get <type> <name>
should be a single object rather than a list
@@ -0,0 +1,15 @@ | |||
items: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output of kumactl get <type> <name>
should be a single object rather than a list
|
||
args := append([]string{ | ||
"--config-file", filepath.Join("..", "testdata", "sample-kumactl.config.yaml"), | ||
"get", "traffic-logs", "web2-to-backend2.namespace2"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a test case for kubernetes
environment (because of web2-to-backend2.namespace2
).
We also need a test case for universal
environment (i.e. web2-to-backend2
)
Checking in to see if you were able to make any progress on this PR @michal-franc |
|
Hi @yskopets @michal-franc Can I start working on this? |
@tharun208 feel free to revive it but @jakubdyszkiewicz might be best person to ask about this task now |
Done in https://github.com/Kong/kuma/pull/667 Thanks @michal-franc for creating a starting point for @tharun208 |
[WIP]
Summary
This is still a work in progress.
Full changelog
kumactl get
for individual resources, e.g.kumactl get <type> <name>
#283] - Supportkumactl get
for individual resources, e.g.kumactl get <type> <name>
TODO: