feat(kuma-cp) delete related mesh resources with DeleteAll on ResourceManager #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
suggested changes
Oct 15, 2019
yskopets
reviewed
Oct 18, 2019
jakubdyszkiewicz
force-pushed
the
feature/delete-multiple-resources-v2
branch
from
5a651c8 to
d5348ce
Compare
yskopets
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Delete related mesh resources (including secrets) when mesh entity is deleted.
Rework of #312 due to https://github.com/Kong/kuma/pull/312#discussion_r332279987
Full changelog
Issues resolved
Fix #191