Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add proposal for MADS v1 API #1607

Closed
wants to merge 5 commits into from
Closed

docs: add proposal for MADS v1 API #1607

wants to merge 5 commits into from

Conversation

austince
Copy link
Contributor

@austince austince commented Feb 25, 2021

Summary

Coming from this slack conversation, this proposes a v1 API for the MADS observability protocol for exposing externally (i.e. to Prometheus) for service discovery of metrics targets. Please let me know if I've gotten things wrong about the current implementation!

kuma-cp --> MADS v1 HTTP server <--xDS v3--> Prometheus kuma_sd (polling)

This will also support serving multiple versions of the MADs API, so we can provide an easy migration path.

Full changelog

  • Add MADS v1 proposal

Related Issues

Follow Ups

  • We will need to implement the HTTP-variant of the final API
  • We will need to add a client and discovery implementation in Prometheus

@austince austince requested a review from a team as a code owner February 25, 2021 00:18
@austince
Copy link
Contributor Author

austince commented Mar 2, 2021

I started a WIP implementation in the feat/mads/v1 branch (API) (MADS) (Prometheus SD), where I've found that more explicit fields will be easier to implement in the SD on the Prometheus side. Much more refactoring needs to be done on that branch, lot of duplication currently. We'll also need to implement the HTTP server, but the base server in envoyproxy/go-control-plane looks like it will make it not too hard.

I've also implemented the Kuma SD with an xDS HTTP client in my Prometheus fork here.

@austince
Copy link
Contributor Author

austince commented Apr 2, 2021

Closing in favor of: #1753

@austince austince closed this Apr 2, 2021
@austince austince deleted the proposal/mads-v1 branch April 2, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant