fix(kuma-cp) resync IPAM in case of Kuma CP restart #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <[email protected]>
nickolaev
reviewed
Nov 25, 2020
| } | ||
|
|
||
| func IsAddressAlreadyAllocated(err error) bool { | ||
| return err != nil && strings.HasPrefix(err.Error(), "Address already allocated") |
There was a problem hiding this comment.
Hmm, can we have a custom ErrorType and compare against it here? Checking string prefix is probably not the best.
There was a problem hiding this comment.
We already have the same approach in store.go and here error comes from Nordix/simple-ipam library. The only thing we can do is to check it against string literal.
nickolaev
reviewed
Nov 25, 2020
| @@ -41,6 +41,10 @@ func (r *ConfigMapReconciler) Reconcile(req kube_ctrl.Request) (kube_ctrl.Result | |||
| return kube_ctrl.Result{}, nil | |||
| } | |||
|
|
|||
| if err := r.VIPsAllocator.Sync(); err != nil { | |||
There was a problem hiding this comment.
Hmm, why is this one here?
There was a problem hiding this comment.
VIPsAllocator#Start is called only on Universal. On Kubernetes we call VIPsAllocator#CreateOrUpdateVIPConfigby reacting on changes in the cluster.
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]>
Signed-off-by: Ilya Lobkov <[email protected]> # Conflicts: # pkg/dns/vips_allocator.go
jakubdyszkiewicz
approved these changes
Nov 27, 2020
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2020
(cherry picked from commit 7d745d5) # Conflicts: # pkg/dns/vips_allocator.go
nickolaev
pushed a commit
that referenced
this pull request
Dec 1, 2020
* fix(kuma-cp) resync IPAM in case of Kuma CP restart (#1213) (cherry picked from commit 7d745d5) # Conflicts: # pkg/dns/vips_allocator.go * make check Signed-off-by: Ilya Lobkov <[email protected]> Co-authored-by: Ilya Lobkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilya Lobkov [email protected]
Summary
IPAM has to be synced between Kuma CP restarts. This PR fixes it