Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): debugging e2e with ipv6 on self hosted runners #11872

Closed
wants to merge 13 commits into from
Closed

test(e2e): debugging e2e with ipv6 on self hosted runners #11872

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
12bc05b
sync master changes
jijiechen Oct 29, 2024
3c3ad21
remove fixed ipv6 ranges
jijiechen Oct 29, 2024
21e228d
fix ipv6 range
jijiechen Oct 29, 2024
bdf8b7e
debug k8s + ipv6
jijiechen Oct 30, 2024
1203975
don't use GH runners (it's lacking of runners)
jijiechen Oct 30, 2024
11e8136
connect to the runner directly
jijiechen Oct 30, 2024
390fc70
diable golang ci lint
jijiechen Oct 30, 2024
4501ba3
I hope public runners come back
jijiechen Oct 30, 2024
e3f93ee
enlarge the timeout
jijiechen Oct 30, 2024
e2c243b
open all ipv6 e2e cases
jijiechen Oct 30, 2024
9d148a7
Apply suggestions from code review
jijiechen Oct 30, 2024
a28c2ba
Merge branch 'master' into ipv6-on-self-hosted
jijiechen Oct 30, 2024
f9df9ff
try old cidr
jakubdyszkiewicz Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/_e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ jobs:
cat <<'EOF' | sudo tee /etc/docker/daemon.json
{
"ipv6": true,
"fixed-cidr-v6": "2001:db8:1::/64",
"dns": ["8.8.8.8"],
"fixed-cidr-v6": "fd00:fd12:3456::0/64",
"dns-search": ["."]
}
EOF
sudo service docker restart
- name: "Run E2E tests"
# if: false
env:
DOCKERHUB_PULL_CREDENTIAL: ${{ secrets.DOCKERHUB_PULL_CREDENTIAL }}
KUMA_DEBUG: ${{ runner.debug == '1' || vars.ENABLE_E2E_DEBUG_GLOBALLY == 'true' }}
Expand Down Expand Up @@ -131,6 +131,13 @@ jobs:
target="test/e2e"
fi
make ${MAKE_PARAMETERS} CI=true "${target}"
- name: Setup tmate session
uses: mxschmitt/action-tmate@v3
if: false
# if: ${{ failure() }}
timeout-minutes: 60
with:
limit-access-to-actor: true
- uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
if: always()
with:
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ env:
jobs:
test_unit:
timeout-minutes: 20
if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci/skip-test') }}
if: false
# if: ${{ !contains(github.event.pull_request.labels.*.name, 'ci/skip-test') }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
Expand Down Expand Up @@ -50,15 +51,15 @@ jobs:
{
"test_e2e": {
"target": [""],
"k8sVersion": ["kindIpv6", "${{ env.K8S_MIN_VERSION }}", "${{ env.K8S_MAX_VERSION }}"],
"k8sVersion": ["kindIpv6"],
"arch": ["amd64"],
"parallelism": [4],
"cniNetworkPlugin": ["flannel"],
"sidecarContainers": [""]
},
"test_e2e_env": {
"target": ["kubernetes", "universal", "multizone"],
"k8sVersion": ["kind", "kindIpv6", "${{ env.K8S_MAX_VERSION }}"],
"k8sVersion": ["kindIpv6"],
"arch": ["amd64"],
"parallelism": [1],
"cniNetworkPlugin": ["flannel"],
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/build-test-distribute.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ jobs:
go-version-file: go.mod
cache: false
- uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # v6.1.1
if: false
with:
args: --fix=false --verbose
version: v1.60.3
Expand All @@ -66,9 +67,11 @@ jobs:
make dev/tools
- run: |
make clean
- run: |
- if: false
run: |
make check
- id: sca-project
if: false
uses: Kong/public-shared-actions/security-actions/sca@28d20a1f492927f35b00b317acd78f669c45f88b # v2.7.3
with:
dir: .
Expand All @@ -87,7 +90,7 @@ jobs:
uses: ./.github/workflows/_test.yaml
with:
FULL_MATRIX: ${{ needs.check.outputs.FULL_MATRIX }}
RUNNERS_BY_ARCH: ${{ (github.event_name == 'push' || github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) && '{"amd64":"ubuntu-latest","arm64":"ubuntu-latest-arm64-kong"}' || '{"amd64":"ubuntu-latest","arm64":""}' }}
RUNNERS_BY_ARCH: ${{ (github.event_name == 'push' || github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) && '{"amd64":"ubuntu-latest-kong","arm64":"ubuntu-latest-arm64-kong"}' || '{"amd64":"ubuntu-latest","arm64":""}' }}
secrets: inherit
build_publish:
permissions:
Expand Down
4 changes: 2 additions & 2 deletions mk/e2e.new.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ test/e2e-kubernetes: $(E2E_DEPS_TARGETS) $(E2E_K8S_BIN_DEPS) ## Run kubernetes e
$(MAKE) test/e2e/k8s/start/cluster/kuma-1
$(MAKE) test/e2e/k8s/wait/kuma-1
$(MAKE) test/e2e/k8s/load/images/kuma-1
$(E2E_ENV_VARS) $(GINKGO_TEST_E2E) $(KUBE_E2E_PKG_LIST) || (ret=$$?; $(MAKE) test/e2e/k8s/stop/cluster/kuma-1 && exit $$ret)
$(MAKE) test/e2e/k8s/stop/cluster/kuma-1
$(E2E_ENV_VARS) $(GINKGO_TEST_E2E) $(KUBE_E2E_PKG_LIST)
# $(MAKE) test/e2e/k8s/stop/cluster/kuma-1
jijiechen marked this conversation as resolved.
Show resolved Hide resolved

.PHONY: test/e2e-gatewayapi
test/e2e-gatewayapi: $(E2E_DEPS_TARGETS) $(E2E_K8S_BIN_DEPS) ## Run kubernetes e2e tests. Use DEBUG=1 to more easily find issues
Expand Down
6 changes: 3 additions & 3 deletions test/e2e_env/kubernetes/externalservices/externalservices.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ spec:
})

E2EAfterAll(func() {
Expect(kubernetes.Cluster.TriggerDeleteNamespace(clientNamespace)).To(Succeed())
Expect(kubernetes.Cluster.TriggerDeleteNamespace(namespace)).To(Succeed())
Expect(kubernetes.Cluster.DeleteMesh(meshName)).To(Succeed())
//Expect(kubernetes.Cluster.TriggerDeleteNamespace(clientNamespace)).To(Succeed())
jijiechen marked this conversation as resolved.
Show resolved Hide resolved
//Expect(kubernetes.Cluster.TriggerDeleteNamespace(namespace)).To(Succeed())
jijiechen marked this conversation as resolved.
Show resolved Hide resolved
//Expect(kubernetes.Cluster.DeleteMesh(meshName)).To(Succeed())
jijiechen marked this conversation as resolved.
Show resolved Hide resolved
})

Context("non-TLS", func() {
Expand Down
2 changes: 1 addition & 1 deletion test/e2e_env/kubernetes/kubernetes_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ var (
_ = Describe("K8S API Bypass", k8s_api_bypass.K8sApiBypass, Ordered)
_ = Describe("Reachable Services", reachableservices.ReachableServices, Ordered)
_ = Describe("Defaults", defaults.Defaults, Ordered)
_ = Describe("External Services", externalservices.ExternalServices, Ordered)
_ = FDescribe("External Services", externalservices.ExternalServices, Ordered)
jijiechen marked this conversation as resolved.
Show resolved Hide resolved
_ = Describe("External Services Permissive MTLS", externalservices.PermissiveMTLS, Ordered)
_ = Describe("Mesh External Services", meshexternalservices.MeshExternalServices, Ordered)
_ = Describe("ExternalName Services", externalname_services.ExternalNameServices, Ordered)
Expand Down
Loading