-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transparent-proxy): allow --kuma-dp-user
to accept UIDs and deprecate --kuma-dp-uid
flag
#10920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the embedding of the `Executables` struct from `InitializedExecutables` as it is unnecessary. The fields from `Executables` are not used directly in `InitializedExecutables`, and unembedding helps to reduce clutter and improve code clarity. Signed-off-by: Bart Smykla <[email protected]>
Replaced the `IPv6` field in `Config` with the `IPFamilyMode` field. This change centralizes the processing of IP family modes within the `Config` struct, simplifying the configuration and usage. Signed-off-by: Bart Smykla <[email protected]>
Updated the unit tests to align with recent changes in handling IPv4 and IPv6 rules generation. Removed the use of `subnetPlaceholder` and unified the IP address for inbound traffic in tests, as there is no different inbound redirection port for IPv6 now. Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
added
ci/skip-e2e-test
PR: Don't run e2e tests
ci/run-full-matrix
PR: Runs all possible e2e test combination (expensive use carefully)
and removed
ci/skip-e2e-test
PR: Don't run e2e tests
labels
Jul 17, 2024
bartsmykla
changed the title
refactor(transparent-proxy): improvements in tproxy config
feat(transparent-proxy): allow Jul 17, 2024
--kuma-dp-user
to accept UIDs and deprecate --kuma-dp-uid
flag
- Allow `--kuma-dp-user` flag in `kumactl install transparent-proxy` to accept both usernames and UIDs. - Deprecate `--kuma-dp-uid` flag in favor of the enhanced `--kuma-dp-user` flag. - Make `--kuma-dp-user` flag optional. If not specified, the system will attempt to use a default UID (`5678`) or the default username (`kuma-dp`). - Relocate the user processing logic (searching for the user) to the transparent proxy Config. Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
requested review from
michaelbeaumont and
jakubdyszkiewicz
and removed request for
a team
July 17, 2024 06:55
michaelbeaumont
approved these changes
Jul 17, 2024
lahabana
reviewed
Jul 17, 2024
app/kumactl/cmd/install/testdata/install-transparent-proxy.defaults.golden.txt
Show resolved
Hide resolved
Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
…ents-in-tproxy-config
Signed-off-by: Bart Smykla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Owner UID/Username Processing to Config
--kuma-dp-user
Flag:--kuma-dp-user
flag inkumactl install transparent-proxy
now accepts both usernames and UIDs.--kuma-dp-uid
flag has been deprecated in favor of the enhanced--kuma-dp-user
flag.--kuma-dp-user
flag is now optional. If not specified, the system will attempt to use a default UID (5678
) or the default username (kuma-dp
).Small Improvements and Refactorings
Add
IPFamilyMode
toConfig
and RemoveIPv6
Field:IPv6
field inConfig
with theIPFamilyMode
field.Config
struct, simplifying the configuration and usage.Unembed
Executables
fromInitializedExecutables
:Executables
struct fromInitializedExecutables
.Executables
are not used directly inInitializedExecutables
, and unembedding helps to reduce clutter and improve code clarity.Adjust Unit Tests for
kumactl install transparent-proxy
:subnetPlaceholder
and unified the IP address for inbound traffic in tests, as there is no different inbound redirection port for IPv6 now.Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OSci/
labels to run additional/fewer testsUPGRADE.md
?