fix(kuma-cp): validate the bandwidth strictly

[spacewander]

Checklist prior to review

• Link to relevant issue as well as docs and UI issues --
• This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
• Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Don't forget ci/ labels to run additional/fewer tests
• Do you need to update UPGRADE.md? --
• Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

[spacewander]

The test failed because unit mbps is used:

kuma/pkg/plugins/policies/meshfaultinjection/api/v1alpha1/validator_test.go

Line 37 in 536ea8c

limit: 100mbps

But according to the code in

kuma/pkg/xds/envoy/listeners/v3/util.go

Lines 123 to 134 in 536ea8c

	var factor int // multiply on factor, to convert into kbps
	switch units {
	case "kbps":
	factor = 1
	case "Mbps":
	factor = 1000
	case "Gbps":
	factor = 1000000
	default:
	return 0, errors.New("unsupported unit type")
	}

The unit should be case-sensitive.

Which one needs to be changed?

[slonka]

Which one needs to be changed?

the test in

kuma/pkg/plugins/policies/meshfaultinjection/api/v1alpha1/validator_test.go

Line 37 in 536ea8c

limit: 100mbps

according to https://en.wikipedia.org/wiki/Metric_prefix

[spacewander]

100mbps

So 100mbps means mill-bps. I will vote for changing the test as Envoy itself does not support this unit.

[slonka]

I will vote for changing the test as Envoy itself does not support this unit.

you can just change it

do we need upgrade.md instructions?

[spacewander]

@slonka
Updated.

[slonka]

Need to fix the examples as well https://kuma.io/docs/2.7.x/policies/meshfaultinjection/#configuration

PR https://github.com/kumahq/kuma-website/pull/1819/files