Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide filter by kuma.io/service on */external-services endpoints #5908

Closed
kleinfreund opened this issue Feb 3, 2023 · 4 comments · Fixed by #7810
Closed

Provide filter by kuma.io/service on */external-services endpoints #5908

kleinfreund opened this issue Feb 3, 2023 · 4 comments · Fixed by #7810
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@kleinfreund
Copy link
Contributor

kleinfreund commented Feb 3, 2023 •
edited
Loading

TL;DR: We need a way to retrieve an ExternalService given a ServiceInsight name (which can be different than the ExternalService name) in order to show it in the service detail view.

Description

In order to be able to look up external services by service name (which might be different than the external service name), a filter on the */external-services endpoints will be needed.

This mechanism is needed for the service list and detail views in the GUI where we list services (including external services) based on the service insights API. In order to correctly display data for external services, we need to be able to reference an external service from data that exists on the service insights API.

curl 'http://localhost:5681/meshes/default/external-services?tag=kuma.io/service:httpbin'

This is meant to provide a proper fix for kumahq/kuma-gui#599.
@kleinfreund kleinfreund added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Feb 3, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Feb 6, 2023
@jakubdyszkiewicz
Copy link
Contributor

Triage: provide same filters as for regular DPPs

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label May 8, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@bartsmykla bartsmykla removed the triage/stale Inactive for some time. It will be triaged again label Aug 8, 2023
@kleinfreund kleinfreund mentioned this issue Sep 21, 2023
Merged
@lahabana
Copy link
Contributor

I'm extending this with a way to add filters to any resource type.

lahabana added a commit to lahabana/kuma that referenced this issue Sep 21, 2023
@lahabana
feat(api-server): add filtering on list external-services and dataplanes
f5e9db8 
This also opens the path to adding more filters to the api depending on
the resource descriptor

Fix kumahq#5908

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana mentioned this issue Sep 21, 2023
Merged
6 tasks
lahabana added a commit to lahabana/kuma that referenced this issue Sep 21, 2023
@lahabana
feat(api-server): add filtering on list external-services and dataplanes
e8dede4 
This also opens the path to adding more filters to the api depending on
the resource descriptor

Fix kumahq#5908

Signed-off-by: Charly Molter <[email protected]>
lahabana added a commit that referenced this issue Sep 25, 2023
@lahabana
feat(api-server): add filtering on list external-services and datapla…
95ab6f4 
…nes (#7810)

* feat(api-server): add filtering on list external-services and dataplanes

This also opens the path to adding more filters to the api depending on
the resource descriptor

Fix #5908

Signed-off-by: Charly Molter <[email protected]>

* fix nil dereference

Signed-off-by: Charly Molter <[email protected]>

---------

Signed-off-by: Charly Molter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api-server): add filtering on list external-services and dataplanes lahabana/kuma
5 participants
@lahabana @jakubdyszkiewicz @kleinfreund @bartsmykla @lukidzi