feat(kumactl) traffic logging plurar form

app/kumactl/cmd/get/get.go

@@ -29,6 +29,6 @@ func NewGetCmd(pctx *kumactl_cmd.RootContext) *cobra.Command {
 	cmd.AddCommand(newGetDataplanesCmd(ctx))
 	cmd.AddCommand(newGetProxyTemplatesCmd(ctx))
 	cmd.AddCommand(newGetTrafficPermissionsCmd(ctx))
-	cmd.AddCommand(newGetTrafficLoggingCmd(ctx))
+	cmd.AddCommand(newGetTrafficLoggingsCmd(ctx))
 	return cmd
 }

app/kumactl/cmd/get/get_traffic_logging.go → app/kumactl/cmd/get/get_traffic_loggings.go

@@ -13,10 +13,10 @@ import (
 	"github.com/spf13/cobra"
 )
 
-func newGetTrafficLoggingCmd(pctx *getContext) *cobra.Command {
+func newGetTrafficLoggingsCmd(pctx *getContext) *cobra.Command {
 	cmd := &cobra.Command{
-		Use:   "traffic-logging",
-		Short: "Show TrafficLogging",
+		Use:   "traffic-loggings",
+		Short: "Show TrafficLoggings",
 		Long:  `Show TrafficLogging entities.`,
 		RunE: func(cmd *cobra.Command, _ []string) error {
 			rs, err := pctx.CurrentResourceStore()

app/kumactl/cmd/get/get_trafficlogging_test.go → app/kumactl/cmd/get/get_trafficloggings_test.go

@@ -24,7 +24,7 @@ import (
 	"github.com/spf13/cobra"
 )
 
-var _ = Describe("kumactl get traffic-logging", func() {
+var _ = Describe("kumactl get traffic-loggings", func() {
 
 	trafficLoggingResources := []*mesh.TrafficLoggingResource{
 		{
@@ -129,12 +129,12 @@ var _ = Describe("kumactl get traffic-logging", func() {
 			matcher      func(interface{}) gomega_types.GomegaMatcher
 		}
 
-		DescribeTable("kumactl get traffic-logging -o table|json|yaml",
+		DescribeTable("kumactl get traffic-loggings -o table|json|yaml",
 			func(given testCase) {
 				// given
 				rootCmd.SetArgs(append([]string{
 					"--config-file", filepath.Join("..", "testdata", "sample-kumactl.config.yaml"),
-					"get", "traffic-logging"}, given.outputFormat))
+					"get", "traffic-loggings"}, given.outputFormat))
 
 				// when
 				err := rootCmd.Execute()
@@ -150,26 +150,26 @@ var _ = Describe("kumactl get traffic-logging", func() {
 			},
 			Entry("should support Table output by default", testCase{
 				outputFormat: "",
-				goldenFile:   "get-traffic-logging.golden.txt",
+				goldenFile:   "get-traffic-loggings.golden.txt",
 				matcher: func(expected interface{}) gomega_types.GomegaMatcher {
 					return WithTransform(strings.TrimSpace, Equal(strings.TrimSpace(string(expected.([]byte)))))
 				},
 			}),
 			Entry("should support Table output explicitly", testCase{
 				outputFormat: "-otable",
-				goldenFile:   "get-traffic-logging.golden.txt",
+				goldenFile:   "get-traffic-loggings.golden.txt",
 				matcher: func(expected interface{}) gomega_types.GomegaMatcher {
 					return WithTransform(strings.TrimSpace, Equal(strings.TrimSpace(string(expected.([]byte)))))
 				},
 			}),
 			Entry("should support JSON output", testCase{
 				outputFormat: "-ojson",
-				goldenFile:   "get-traffic-logging.golden.json",
+				goldenFile:   "get-traffic-loggings.golden.json",
 				matcher:      MatchJSON,
 			}),
 			Entry("should support YAML output", testCase{
 				outputFormat: "-oyaml",
-				goldenFile:   "get-traffic-logging.golden.yaml",
+				goldenFile:   "get-traffic-loggings.golden.yaml",
 				matcher:      MatchYAML,
 			}),
 		)

app/kumactl/data/install/k8s/control-plane/kuma-cp/rbac.yaml

@@ -56,6 +56,14 @@ rules:
   - get
   - list
   - watch
+- apiGroups:
+  - kuma.io
+  resources:
+  - trafficloggings
+  verbs:
+  - get
+  - list
+  - watch
 # validate k8s token before issueing mTLS cert
 - apiGroups:
   - authentication.k8s.io

docs/cmd/kumactl/HELP.md

@@ -246,6 +246,7 @@ Available Commands:
   dataplanes          Show Dataplanes
   meshes              Show Meshes
   proxytemplates      Show ProxyTemplates
+  traffic-loggings    Show TrafficLoggings
   traffic-permissions Show TrafficPermissions
 
 Flags:

examples/minikube/kumactl_workflow.sh

@@ -46,6 +46,8 @@ run kumactl get proxytemplates
 
 run kumactl get traffic-permissions
 
+run kumactl get traffic-loggings
+
 run kumactl inspect dataplanes
 
 run kumactl inspect dataplanes -otable

pkg/plugins/resources/k8s/native/api/v1alpha1/trafficlogging_types.go

@@ -26,8 +26,6 @@ import (
 // TrafficLoggingSpec defines the desired state of TrafficLogging
 type TrafficLoggingSpec = map[string]interface{}
 
-// +kubebuilder:object:root=true
-
 // TrafficLogging is the Schema for the trafficloggings API
 type TrafficLogging struct {
 	metav1.TypeMeta   `json:",inline"`
@@ -37,8 +35,6 @@ type TrafficLogging struct {
 	Spec TrafficLoggingSpec `json:"spec,omitempty"`
 }
 
-// +kubebuilder:object:root=true
-
 // TrafficLoggingList contains a list of TrafficLogging
 type TrafficLoggingList struct {
 	metav1.TypeMeta `json:",inline"`

pkg/plugins/resources/k8s/native/main.go

@@ -36,7 +36,6 @@ var (
 
 func init() {
 
-	meshv1alpha1.AddToScheme(scheme)
 	_ = meshv1alpha1.AddToScheme(scheme)
 	// +kubebuilder:scaffold:scheme
 }