feat(kuma-cp): map BadRequest error to 400 (#8312)

Signed-off-by: Lukasz Dziedziak <[email protected]>
kumahq · Nov 13, 2023 · 07fcbed · 07fcbed
1 parent f806219
commit 07fcbed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/core/rest/errors/error_handler.go b/pkg/core/rest/errors/error_handler.go
@@ -33,7 +33,7 @@ func HandleError(ctx context.Context, response *restful.Response, err error, tit
 			Title:  title,
 			Detail: "Not found",
 		}
-	case errors.Is(err, &rest.InvalidResourceError{}) || errors.Is(err, &registry.InvalidResourceTypeError{}) || errors.Is(err, &store.PreconditionError{}):
+	case errors.Is(err, &rest.InvalidResourceError{}), errors.Is(err, &registry.InvalidResourceTypeError{}), errors.Is(err, &store.PreconditionError{}), errors.Is(err, &BadRequest{}):
 		kumaErr = &types.Error{
 			Status: 400,
 			Title:  "Bad Request",

diff --git a/pkg/core/rest/errors/errors.go b/pkg/core/rest/errors/errors.go
@@ -38,7 +38,7 @@ func NewBadRequestError(msg string) error {
 }
 
 func (e *BadRequest) Error() string {
-	if e.msg != "" {
+	if e.msg == "" {
 		return "bad request"
 	}
 	return fmt.Sprintf("bad request: %s", e.msg)