Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): updates all dependencies #471

Merged
merged 3 commits into from
Nov 29, 2022
Merged

chore(deps): updates all dependencies #471

merged 3 commits into from
Nov 29, 2022

Conversation

kleinfreund
Copy link
Contributor

@kleinfreund kleinfreund commented Nov 23, 2022

Updates all dependencies.

Removes data-v attributes from snapshots to avoid minor/patch releases of Kongponents to breaking our tests solely on account of all the data-v attributes changing.

Adds workaround plugin for Vite issue vitejs/vite#2415.

Signed-off-by: Philipp Rudloff [email protected]

@kleinfreund kleinfreund self-assigned this Nov 23, 2022
@kleinfreund kleinfreund requested a review from a team November 23, 2022 08:50
@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 69bb4db
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/6385c65b1848660008315a7d
😎 Deploy Preview https://deploy-preview-471--kuma-gui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kleinfreund kleinfreund changed the title chore(deps): pins all dependencies chore(deps): updates all dependencies Nov 24, 2022
@kleinfreund
Copy link
Contributor Author

Comment: Need to tweak the removal of data-v-* attributes a bit more.

Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I had a question on the data-v attributes but thats non-blocking

Philipp Rudloff added 3 commits November 29, 2022 09:39
Updates all dependencies.

Removes `data-v` attributes from snapshots to avoid minor/patch releases of Kongponents to breaking our tests solely on account of all the `data-v` attributes changing.

Adds workaround plugin for Vite issue vitejs/vite#2415.

Signed-off-by: Philipp Rudloff <[email protected]>
Removes the `getTableData` function and its related utilities in favor of direct API calls in components which allows for more precise type inference.

Signed-off-by: Philipp Rudloff <[email protected]>
@kleinfreund kleinfreund merged commit 2192080 into kumahq:master Nov 29, 2022
@kleinfreund kleinfreund deleted the chore/pin-dependencies branch November 29, 2022 08:49
@kleinfreund kleinfreund removed their assignment Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants