Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid arch infos from native runtimes #75

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

alkee
Copy link
Contributor

@alkee alkee commented Dec 31, 2023

No description provided.

Copy link
Owner

@kumaS-nu kumaS-nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the no longer needed code, there is no problem. This pull request is good.

@@ -133,7 +133,8 @@ string pluginPath
platformPath = Path.GetDirectoryName(platformPath);
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer need this code due to your update. (NuGetNativeImportSetting.cs L.130-134)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cleaned up a bit. Thank you.

@kumaS-nu
Copy link
Owner

kumaS-nu commented Jan 1, 2024

Thank you for your contribution.
It's been a while since I've updated, so I need to update GitHub Actions to test this repository. It may take some time to merge your pull request.
I will merge as soon as the test passes.

@alkee alkee requested a review from kumaS-nu January 2, 2024 08:41
Copy link
Owner

@kumaS-nu kumaS-nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaS-nu
Copy link
Owner

kumaS-nu commented Jan 4, 2024

A GitHub change seems to have prevented the secret from being passed to the pull request from the forked repository. The change is acceptable, so I'll merge it in.

@kumaS-nu kumaS-nu merged commit 2cee0a8 into kumaS-nu:main Jan 4, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants