improve mode parameter of count function

kuma3 · Jun 26, 2024 · ae2dc75 · ae2dc75
1 parent 466e677
commit ae2dc75
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/resources/functionMap.php b/resources/functionMap.php
@@ -1365,7 +1365,7 @@
 'Couchbase\WildcardSearchQuery::jsonSerialize' => ['array'],
 'Couchbase\zlibCompress' => ['string', 'data'=>'string'],
 'Couchbase\zlibDecompress' => ['string', 'data'=>'string'],
-'count' => ['0|positive-int', 'var'=>'Countable|array', 'mode='=>'int'],
+'count' => ['0|positive-int', 'var'=>'Countable|array', 'mode='=>'0|1'],
 'count_chars' => ['mixed', 'input'=>'string', 'mode='=>'0|1|2|3|4'],
 'Countable::count' => ['0|positive-int'],
 'crack_check' => ['bool', 'dictionary'=>'', 'password'=>'string'],

diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -1716,4 +1716,18 @@ public function testCountArrayShift(): void
 		$this->analyse([__DIR__ . '/data/count-array-shift.php'], $errors);
 	}
 
+	public function testCount(): void
+	{
+		$this->analyse([__DIR__ . '/data/count.php'], [
+			[
+				'Parameter #2 $mode of function count expects 0|1, -1 given.',
+				9,
+			],
+			[
+				'Parameter #2 $mode of function count expects 0|1, int given.',
+				10,
+			],
+		]);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Functions/data/count.php b/tests/PHPStan/Rules/Functions/data/count.php
@@ -0,0 +1,12 @@
+<?php declare(strict_types=1);
+
+namespace Count;
+
+class Foo 
+{
+    public function doFoo(int $mode): void
+    {
+        count([1, 2, 3], -1);
+        count([1, 2, 3], $mode);       
+    }
+}