Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix link #4192

Merged
merged 2 commits into from
Aug 20, 2023
Merged

docs: fix link #4192

merged 2 commits into from
Aug 20, 2023

Conversation

revolunet
Copy link
Contributor

@revolunet revolunet commented Jul 26, 2023

Summary

Fix a link in the docs

Test plan

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kulshekhar
Copy link
Owner

kulshekhar commented Aug 16, 2023

The link seems to be working fine 🤔

image

@revolunet
Copy link
Contributor Author

revolunet commented Aug 16, 2023

Hi, in some cases, we land on the docs URL with an ending slash /. When that happens, relative links are broken.

https://kulshekhar.github.io/ts-jest/docs/getting-started/installation/

@kulshekhar
Copy link
Owner

aah, you're right.

kulshekhar
kulshekhar previously approved these changes Aug 16, 2023
@kulshekhar
Copy link
Owner

Thank you @revolunet

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5666659865

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 95.993%

Totals Coverage Status
Change from base Build 5517569175: 0.03%
Covered Lines: 4055
Relevant Lines: 4154

💛 - Coveralls

@kulshekhar
Copy link
Owner

The lint check seems to be failing

@kulshekhar kulshekhar merged commit 9f1439a into kulshekhar:main Aug 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants