Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): 28.0.6 #3684

Merged
merged 1 commit into from
Jul 14, 2022
Merged

chore(release): 28.0.6 #3684

merged 1 commit into from
Jul 14, 2022

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Jul 13, 2022

No description provided.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner July 13, 2022 20:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2666043411

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.971%
Totals Coverage Status
Change from base Build 2666021441: 0.0%
Covered Lines: 1119
Relevant Lines: 1156
💛 - Coveralls

@ahnpnl ahnpnl merged commit 6f83155 into kulshekhar:main Jul 14, 2022
@ahnpnl ahnpnl deleted the release-28.0.6 branch July 14, 2022 04:47
@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Jul 14, 2022

@kulshekhar it seems like there is an issue with permission for bot to publish but I don’t know exactly what it is https://github.com/kulshekhar/ts-jest/runs/7333776561?check_suite_focus=true Would you please take a look?

@kulshekhar
Copy link
Owner

@ahnpnl this might have something to do with npm permissions - I'll take a look after work today

@kulshekhar
Copy link
Owner

actually, this looks like a different issue. Rerunning this failed because the tag already exists. I think this might be a one off.

@ahnpnl should we try again with a new minor version to see if this issue pops up again?

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Jul 14, 2022

Yes we can create a new tag from publish page and the workflow will run again

@kulshekhar
Copy link
Owner

There's a different error in this run 🤔
image

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Jul 16, 2022 •
edited
Loading

Between 28.0.5 and 28.0.6 we have one PR #3653 which is related to automatic release. But this one only applies to documentation publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahnpnl @coveralls @kulshekhar