Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): make projectReferences work with isolatedModules: true #1527

Merged
merged 3 commits into from
Apr 16, 2020
Merged

fix(compiler): make projectReferences work with isolatedModules: true #1527

merged 3 commits into from
Apr 16, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 15, 2020

Summary

A part of work for #766

Inspired from TypeStrong/ts-loader#817 , this PR is to make projectReferences work with isolatedModules: true

Caveat
It is required to build the project first with tsc -b to have the compiled files ready. We can look into including this tsc -b step as improvement later.

Test plan

Added e2e tests with the example repo from #766

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

There will be similar work for LanguageService which will be in another PR

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 15, 2020 14:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4414

  • 33 of 33 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 93.036%

Totals Coverage Status
Change from base Build 4411: 0.09%
Covered Lines: 1184
Relevant Lines: 1219

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants