Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jest@test version #282

Closed
screendriver opened this issue Jul 28, 2017 · 6 comments
Closed

Support jest@test version #282

screendriver opened this issue Jul 28, 2017 · 6 comments

Comments

@screendriver
Copy link
Contributor

  • Issue

It would be cool if you upgrade your Jest peerDependency to the latest test version of Jest. At the moment I'm getting "ts-jest#jest@^20.0.0" doesn't satisfy found match of "[email protected]"

The reason for trying out the latest delta version is this issue jestjs/jest#4088 that I am encountering all the time.

Thanks ☺️

@kulshekhar
Copy link
Owner

@screendriver wouldn't ^20.0.0 use the latest version in the 20.x.x range?

@screendriver
Copy link
Contributor Author

Should be, yes. But yarn check complains about it.

[foo-shell:~/development/project]$ yarn check
yarn check v0.27.5
warning package.json: No license field
warning [email protected]: No license field
error "ts-jest#jest@^20.0.0" doesn't satisfy found match of "[email protected]"

@kulshekhar
Copy link
Owner

I need some help here. If the peer dependency requirement needs to change, can you tell me what it should be such that it allows all jest versions in a specified 'major' range?

@screendriver
Copy link
Contributor Author

Good question. To be honest I don't know. I thought the same like you.

@pelotom
Copy link
Contributor

pelotom commented Aug 29, 2017

From here,

If a version has a prerelease tag (for example, 1.2.3-alpha.3) then it will only be allowed to satisfy comparator sets if at least one comparator with the same [major, minor, patch] tuple also has a prerelease tag.

The current jest@test is up to v21.0.0-beta.1, so I think we need to use a version range of

"jest": "^20.0.0 >=21.0.0-beta.1"

pelotom added a commit to pelotom/ts-jest that referenced this issue Aug 29, 2017
@gdborton
Copy link

@kulshekhar You can test the semver values here - https://semver.npmjs.com/

"^20.0.0 || > 21.0.0-alpha || > 20.1.0-alpha" matches everything in 20.x, 20.1 prereleases, and current 21.0 prereleases.

Sadly npm doesn't seem to have a simple way of saying match > 20.x.x-alpha.

kulshekhar pushed a commit that referenced this issue Aug 30, 2017
Support prerelease version of Jest 21

Resolves #282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants