Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: husky で commitlint を実行するように修正 #1960

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

nabeliwo
Copy link
Member

Related URL

🍐

Overview

  • いつの間にか husky で commitlint を実行しないようになっていた
  • commitlint も husky の新しい設定で動かしたい

What I did

  • commitlint の実行を新しい husky の設定にあわせた
  • 古い設定ファイルが残っていたのでそちらは削除した

Capture

🍐

@nabeliwo nabeliwo requested a review from a team as a code owner October 11, 2021 03:49
@nabeliwo nabeliwo requested review from im36-123 and yamakeeeeeeeeen and removed request for a team October 11, 2021 03:49
@nabeliwo nabeliwo requested a review from wmoai October 11, 2021 03:50
@reg-suit
Copy link

reg-suit bot commented Oct 11, 2021

✨✨ That's perfect, there is no visual difference! ✨✨

Check out the report here.

@netlify
Copy link

netlify bot commented Oct 11, 2021

✔️ Deploy Preview for smarthr-ui ready!

🔨 Explore the source changes: 0a0f99e

🔍 Inspect the deploy log: https://app.netlify.com/sites/smarthr-ui/deploys/6163b43f60fde0000899a40b

😎 Browse the preview: https://deploy-preview-1960--smarthr-ui.netlify.app

@netlify
Copy link

netlify bot commented Oct 11, 2021

✔️ Deploy Preview for smarthr-ui ready!

🔨 Explore the source changes: c9ec18c

🔍 Inspect the deploy log: https://app.netlify.com/sites/smarthr-ui/deploys/6163b464a8c9d300072258a7

😎 Browse the preview: https://deploy-preview-1960--smarthr-ui.netlify.app

Copy link
Contributor

@wmoai wmoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動くことを確認しました!
LGTM !

@nabeliwo nabeliwo merged commit 9adeb91 into master Oct 12, 2021
@nabeliwo nabeliwo deleted the fix-husky branch October 12, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants