fix: DialogContentInner の className が Wrraper にあたっていたのを Inner に戻す #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uknmr
requested review from
shinji-hagiwara and
MRTAFU
and removed request for
a team
|
✨✨ That's perfect, there is no visual difference! ✨✨ Check out the report here. |
|
✔️ Deploy Preview for smarthr-ui ready! 🔨 Explore the source changes: dec4854 🔍 Inspect the deploy log: https://app.netlify.com/sites/smarthr-ui/deploys/60d2b5bedfc5640008d4a091 😎 Browse the preview: https://deploy-preview-1695--smarthr-ui.netlify.app/iframe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1514 で Inner にあたっていた
classNameが Wrapper に移動し、既存アプリケーションに影響を与えていたので修正。コンポーネントとして Dialog の実態は Wrapper ではなく Inner なので想像する使用感とも合致しそう。
93a345d#diff-23541497bd86a5f30d84af5daeff6522a804e0dab196d2ce0d3742002742011aR128-R142
Story で
const MessageDiaglo = styled(shrMessageDialog)``として確認済み。