Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/store conf #140

Merged
merged 10 commits into from
Feb 19, 2023
Merged

Fix/store conf #140

merged 10 commits into from
Feb 19, 2023

Conversation

RoMi1981
Copy link
Contributor

@RoMi1981 RoMi1981 commented Feb 6, 2023

No description provided.

ocean-client/src/utils/store_config.ts Outdated Show resolved Hide resolved
ocean-client/src/utils/store_config.ts Outdated Show resolved Hide resolved
ocean-client/src/vault-maxi.ts Outdated Show resolved Hide resolved
ocean-client/src/vault-maxi.ts Outdated Show resolved Hide resolved
@RoMi1981 RoMi1981 closed this Feb 14, 2023
@kuegi
Copy link
Owner

kuegi commented Feb 19, 2023

@RoMi1981 why did you close it? should be fine to merge, right?

@kuegi kuegi reopened this Feb 19, 2023
back to logid logic. should be fine like this
@kuegi
Copy link
Owner

kuegi commented Feb 19, 2023

@Krysh90 fine for you?

@Krysh90
Copy link
Collaborator

Krysh90 commented Feb 19, 2023

same as on the other PR. I am completely fine if we support Docker. Even better if a docker user can verify that the code is equal to our repo, same as we have for our zips with the sha hash

@kuegi kuegi merged commit c2d1896 into kuegi:develop Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants