Child params in operators with dependencies failing in pkg resolver #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alena Varkockova <[email protected]>
alenkacz
force-pushed
the
av/dep-params
branch
3 times, most recently
from
d99bc2b
to
e00806c
Compare
|
The operator test failure is OK, it's because I've cleaned up the operators folder |
alenkacz
changed the title
Signed-off-by: Alena Varkockova <[email protected]>
alenkacz
force-pushed
the
av/dep-params
branch
from
e00806c
to
384182c
Compare
Signed-off-by: Alena Varkockova <[email protected]>
alenkacz
force-pushed
the
av/dep-params
branch
from
0995062
to
714dc06
Compare
kensipe
approved these changes
Mar 12, 2021
| @@ -85,7 +85,7 @@ lint: ## Run golangci-lint | |||
| ifneq (${GOLANGCI_LINT_VER}, "$(shell golangci-lint version --format short 2>&1)") | |||
| ./hack/install-golangcilint.sh ${GOLANGCI_LINT_VER} | |||
| endif | |||
| golangci-lint --timeout 3m run --allow-parallel-runners | |||
| golangci-lint --timeout 4m run --allow-parallel-runners | |||
| @@ -30,6 +30,12 @@ func (ReferenceVerifier) Verify(pf *packages.Files) verifier.Result { | |||
| resources = task.Spec.ResourceTaskSpec.Resources | |||
| case engtask.PipeTaskKind: | |||
| resources = append(resources, task.Spec.PipeTaskSpec.Pod) | |||
| case engtask.KudoOperatorTaskKind: | |||
| // param file is being stored in the templates folder, we need to make sure it's in here | |||
| // to not treat it as error | |||
| if err != nil { | ||
| res.AddErrors(fmt.Sprintf("parsing rendered YAML from %s failed: %v", k, err)) | ||
| // parameter file for KudoOperator task does not have to parse to kubernetes object | ||
| if !isParameterFile(k, pf) { |
There was a problem hiding this comment.
not a big deal... but I'm wondering if we have have a
if isParameterFile() that continues and reduce the indent on the error handling
From a Go perspective, it feels like a lot of nesting... reasonable to keep as well
|
@asekretenko merged :) thanks for review @kensipe I missed that you approved, appreciate it! It is such a long time I've implemented this though that I don't remember some of the implementation details :D |
alenkacz
added a commit
that referenced
this pull request
Apr 21, 2021
…1773) * Add failing test for depencencies with child params Signed-off-by: Alena Varkockova <[email protected]> * Fix verifier handling of child params files Signed-off-by: Alena Varkockova <[email protected]> * Increase timeout Signed-off-by: Alena Varkockova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #1772