Skip to content
This repository has been archived by the owner on May 24, 2021. It is now read-only.

Before failure fix #21

Closed
wants to merge 2 commits into from
Closed

Conversation

drewbrend
Copy link

@drewbrend drewbrend commented Sep 9, 2019

@bkucera This fixes #20

You can see with the demonstration test (same test linked in that issue) that it now fails with the correct error both times and all existing tests in this repo are passing.

I have tried writing a test that captures this issue but passes, I haven't been successful and have run out of time and need to get back to company work.

If you're okay with the fix not having tests associated, the demonstration test can be dropped and merging this will fix the issue. Otherwise, feel free to write some better tests :)

@kuceb
Copy link
Owner

kuceb commented Sep 9, 2019

thanks @drewbrend , I'll clean this up to have a passing test and merge it in

@kuceb
Copy link
Owner

kuceb commented Sep 10, 2019

I don't like working on top of forks, so I'm closing this for #22 (I've kept your commits)

@kuceb kuceb closed this Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in before() block is ignored if RETRIES is greater than zero
2 participants