(Nix) Allow for specifying include/library paths #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dminuoso |
|
@kubo I did not realize that I deleted one line too many. It's fixed |
|
@dminuoso Thanks. It was merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this package is not buildable on Nix for a few reasons.
It uses a hardcoded
/sbin/ldconfigreference, requires LD_LIBRARY_PATH hacks to introduce oracle-instantclient to the extconf.rb process, and the package further assumes some special directory structure (which the oracle-instantclient package from nixpkgs does not follow)..Rather than try identifying nix and special casing the lib/include paths, it is easier if nix can control the lib/include paths itself.
This patch adds support for three flags.
--with-instant-client-dir,--with-instant-client-includeand--with-instant-client-lib. The behavior of the package is left unchanged if those flags are not specified.