remove source maps from distributed package #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately, when it comes to the decision over which files to publish in the distributed package, there are two options to consider:
sources
&source maps
.sources
norsource maps
.This is because, fundamentally, in order for end users to use
source maps
for debugging purposes, they would need the associatedsources
available in the package.Given that we currently do not currently publish
sources
: option 1 would mean addingsources
to the package, whereas option 2 would be to remove thesource maps
. And after somenpm publish --dry-run
testing, the differential end result is that addingsources
would increase the package size by ~100% over removingsource maps
.Further reading on the discussion: googleapis/google-cloud-node#2867