Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove source maps from distributed package #46

Merged
merged 1 commit into from
Oct 31, 2022
Merged

remove source maps from distributed package #46

merged 1 commit into from
Oct 31, 2022

Conversation

kubikowski
Copy link
Owner

@kubikowski kubikowski commented Oct 31, 2022

Ultimately, when it comes to the decision over which files to publish in the distributed package, there are two options to consider:

  1. Publish both sources & source maps.
  2. Publish neither sources nor source maps.

This is because, fundamentally, in order for end users to use source maps for debugging purposes, they would need the associated sources available in the package.

Given that we currently do not currently publish sources: option 1 would mean adding sources to the package, whereas option 2 would be to remove the source maps. And after some npm publish --dry-run testing, the differential end result is that adding sources would increase the package size by ~100% over removing source maps.

Further reading on the discussion: googleapis/google-cloud-node#2867

@kubikowski kubikowski added type: Bug something isn't working code: DevOps automate everything labels Oct 31, 2022
@kubikowski kubikowski added this to the v1.5.0 milestone Oct 31, 2022
@kubikowski kubikowski self-assigned this Oct 31, 2022
@kubikowski kubikowski merged commit 872a254 into main Oct 31, 2022
@kubikowski kubikowski deleted the package branch October 31, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code: DevOps automate everything type: Bug something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant