Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce move_pages granularity #676

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yadzhang
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@yadzhang yadzhang requested a review from csfldf as a code owner August 16, 2024 03:32
@yadzhang yadzhang changed the title reduce move_pages granularity [Draft] reduce move_pages granularity Aug 16, 2024
@yadzhang yadzhang marked this pull request as draft August 16, 2024 03:33
@yadzhang yadzhang changed the title [Draft] reduce move_pages granularity reduce move_pages granularity Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 56.90%. Comparing base (c44f3bb) to head (86cc486).
Report is 1 commits behind head on main.

Files Patch % Lines
...m-plugins/memory/dynamicpolicy/util_linux_amd64.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
+ Coverage   56.89%   56.90%   +0.01%     
==========================================
  Files         556      556              
  Lines       53314    53323       +9     
==========================================
+ Hits        30333    30346      +13     
- Misses      19157    19164       +7     
+ Partials     3824     3813      -11     
Flag Coverage Δ
unittest 56.90% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -390,6 +401,7 @@ pagesLoop:
errList = append(errList, fmt.Errorf("failed move pages for pid: %d, numa: %d err: %v", pid, dstNuma, err))
continue
}
moveCount = moveCount + 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moveCount++

@yadzhang yadzhang force-pushed the feat/reduce_move_pages branch 2 times, most recently from 4d97803 to ccb01b7 Compare August 21, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants