Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(metaserver): refactor notify init in metaserver #596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itonyli
Copy link

@itonyli itonyli commented May 28, 2024

What type of PR is this?

Refactor

What this PR does / why we need it:

Simplify Notify registration for different metrics through the closure method.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Simplify Notify registration for different metrics through the closure method.
@itonyli itonyli requested a review from nightmeng as a code owner May 28, 2024 07:01
@CLAassistant
Copy link

CLAassistant commented May 28, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.20%. Comparing base (5e1814b) to head (0e00bfe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   56.14%   56.20%   +0.05%     
==========================================
  Files         535      535              
  Lines       49865    49821      -44     
==========================================
+ Hits        27997    28000       +3     
+ Misses      18307    18278      -29     
+ Partials     3561     3543      -18     
Flag Coverage Δ
unittest 56.20% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants