Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ORM): add orm podResources server #453

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

WangZzzhe
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

Add v1 podResources server for ORM.
Topology allocated and allocatable resources from registered QRM plugins can be requested through [�List] and [GetAllocatableResources] api.
ORM also request device resource from kubelet and merge datas to podResources response, it can be configured with katalyst-agent custom args.

Which issue(s) this PR fixes:

#430

image

@WangZzzhe WangZzzhe added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jan 22, 2024
@WangZzzhe WangZzzhe self-assigned this Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 148 lines in your changes are missing coverage. Please review.

Project coverage is 55.80%. Comparing base (b122f7b) to head (36656f0).
Report is 18 commits behind head on main.

❗ Current head 36656f0 differs from pull request most recent head b4f1665. Consider uploading reports for the commit b4f1665 to get more accurate results

Files Patch % Lines
pkg/agent/orm/resourceprovider.go 56.17% 63 Missing and 15 partials ⚠️
pkg/agent/orm/manager.go 9.09% 20 Missing ⚠️
pkg/agent/orm/deviceprovider/kubelet/provider.go 80.64% 9 Missing and 3 partials ⚠️
pkg/agent/orm/metamanager/manager.go 52.63% 7 Missing and 2 partials ⚠️
...t/resourcemanager/fetcher/kubelet/kubeletplugin.go 63.15% 4 Missing and 3 partials ⚠️
cmd/katalyst-agent/app/options/orm/orm_base.go 64.70% 6 Missing ⚠️
pkg/agent/orm/endpoint/endpoint.go 57.14% 4 Missing and 2 partials ⚠️
pkg/agent/orm/server/server.go 50.00% 4 Missing and 2 partials ⚠️
pkg/agent/orm/server/podresources/types.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   55.67%   55.80%   +0.12%     
==========================================
  Files         552      558       +6     
  Lines       59419    59846     +427     
==========================================
+ Hits        33083    33398     +315     
- Misses      22899    22979      +80     
- Partials     3437     3469      +32     
Flag Coverage Δ
unittest 55.80% <69.23%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348
Copy link
Collaborator

need to rebase before it can be merged @WangZzzhe @caohe

@WangZzzhe
Copy link
Collaborator Author

need to rebase before it can be merged @WangZzzhe @caohe

Done.

@waynepeking348
Copy link
Collaborator

@luomingmeng pls have a look at this pr to make sure it is compatible with the original implementation for reporter

caohe
caohe previously approved these changes Apr 10, 2024
@luomingmeng luomingmeng merged commit 5268e8e into kubewharf:main Apr 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants