Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support resource portrait #86

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

kapybar4
Copy link
Contributor

@kapybar4 kapybar4 commented May 23, 2024

What type of PR is this?

Enhancements

What this PR does / why we need it:

This PR is used to support SPD's resource portrait plug-in. The main changes include adding a new configuration type ResourcePortraitConfiguration and expanding SPD semantics.

  • Although ResourcePortraitConfiguration is defined in the form of CRD, it is only used to inject into the RawExtension of SPD, and there is no need to create the resources corresponding to the CRD in the cluster.
  • SPD's AggPodMetrics field adds a Scope field, whose semantics are similar to Scope in NPD, for use by plug-ins. A plug-in can freely create multiple Scopes to distinguish different indicator sequences. At the same time, Aggregator field extends the AggregatorRaw type to represent temporary data generated by the plug-in.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@CLAassistant
Copy link

CLAassistant commented May 23, 2024

CLA assistant check
All committers have signed the CLA.

@kapybar4 kapybar4 force-pushed the feat-resource-portrait branch 5 times, most recently from e016e83 to 2d2320c Compare May 27, 2024 19:08
pkg/apis/config/v1alpha1/rpc.go Outdated Show resolved Hide resolved
pkg/apis/config/v1alpha1/rpc.go Outdated Show resolved Hide resolved
@luomingmeng luomingmeng added workflow/need-review review: test succeeded, need to review enhancement New feature or request labels Jun 5, 2024
@waynepeking348 waynepeking348 merged commit de2f4ec into kubewharf:main Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

6 participants