add sum aggregator and memory bandwidth aggregate metric name #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luomingmeng
added
enhancement
pkg/consts/spd.go
Outdated
| @@ -42,3 +42,9 @@ const ( | |||
| SPDBaselinePercentMax = 100 | |||
| SPDBaselinePercentMin = 0 | |||
| ) | |||
|
|
|||
| // resource names for aggregate metric | |||
There was a problem hiding this comment.
why resource name is defined in spd.go?
There was a problem hiding this comment.
This is just the metric name not the resource name, it has been modified to the metric name.
luomingmeng
force-pushed
the
dev/workload-add-sum-aggregator
branch
from
4aa8ae4
to
bcc67cc
Compare
waynepeking348
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
add sum aggregator and memory bandwidth aggregate metric name
Which issue(s) this PR fixes:
Special notes for your reviewer: