feat(kcnr): add node metric #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheney-lin
added
enhancement
cheney-lin
force-pushed
the
dev/node_metric
branch
4 times, most recently
from
aa1f9ea
to
49cccfb
Compare
luomingmeng
previously approved these changes
Feb 20, 2024
cheney-lin
added
workflow/merge-ready
| ResourceUsage `json:",inline"` | ||
| } | ||
|
|
||
| type NUMAMetricInfo struct { |
There was a problem hiding this comment.
why we need per-numa level data
There was a problem hiding this comment.
for numa aware scheduling
pkg/apis/node/v1alpha1/types.go
Outdated
| // NUMAUsage contains the real-time resource usage for each NUMA | ||
| NUMAUsage []NUMAMetricInfo `json:"numaUsage,omitempty"` | ||
|
|
||
| // GenericUsage contains the real-time resource usage, in format of '{"cpu": 2, "memory": "1Gi"}' |
There was a problem hiding this comment.
since we already have NUMAUsage why we still need GenericUsage? should we restrict that only one of these two fields is valid?
There was a problem hiding this comment.
Not all metrics can be granularized to the NUMA level，such as network bandwidth.
There was a problem hiding this comment.
ok, so we should restrict that only one of these two fields is valid (for a certain resource)? if so, pls add some comments here
cheney-lin
force-pushed
the
dev/node_metric
branch
from
49cccfb
to
3a1038e
Compare
cheney-lin
force-pushed
the
dev/node_metric
branch
from
3a1038e
to
0898b95
Compare
Signed-off-by: linzhecheng <[email protected]>
cheney-lin
force-pushed
the
dev/node_metric
branch
from
0898b95
to
f5dfa7f
Compare
waynepeking348
approved these changes
Feb 20, 2024
luomingmeng
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: