spd api support custom indicator #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luomingmeng
force-pushed
the
dev/spd-support-custom-indicator
branch
from
20b408b
to
a8f79ed
Compare
cheney-lin
reviewed
Jan 20, 2024
pkg/apis/workload/v1alpha1/types.go
Outdated
| // if multiple CustomIndicator are defined, it means that we should | ||
| // try to satisfy all of those indicator targets | ||
| // +optional | ||
| // +patchMergeKey=name |
There was a problem hiding this comment.
Does patchMergeKey take effected for CRDs?
luomingmeng
force-pushed
the
dev/spd-support-custom-indicator
branch
from
a8f79ed
to
b8e45e1
Compare
csfldf
reviewed
Jan 23, 2024
| @@ -119,12 +144,12 @@ type ServiceBusinessIndicatorSpec struct { | |||
| Indicators []Indicator `json:"indicators,omitempty"` | |||
| } | |||
|
|
|||
| type TargetIndicatorName string | |||
There was a problem hiding this comment.
changing type name, will it cause modifications in codes using this type?
There was a problem hiding this comment.
yes, i will change the code in other mr
pkg/apis/workload/v1alpha1/types.go
Outdated
| // +optional | ||
| // +listMapKey=name | ||
| // +listType=map | ||
| CustomIndicator []ServiceCustomIndicatorSpec `json:"customIndicator,omitempty"` |
There was a problem hiding this comment.
what is the difference between CustomIndicator and BusinessIndicator actually?
luomingmeng
force-pushed
the
dev/spd-support-custom-indicator
branch
2 times, most recently
from
ac95d80
to
0eda6ec
Compare
luomingmeng
force-pushed
the
dev/spd-support-custom-indicator
branch
from
0eda6ec
to
4c501b1
Compare
waynepeking348
approved these changes
Feb 21, 2024
csfldf
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
extend spd api to support custom indicator beyond business and system scopes
Which issue(s) this PR fixes:
Special notes for your reviewer: