feat(overcommit):add nodeOvercommitConfig crd #34
Conversation
caohe
added
enhancement
| // ResourceOvercommitRatioConfig describes the resource overcommit ratio that needs to inject into Node.Annotations | ||
| // cpu,memory are supported. | ||
| // +optional | ||
| ResourceOvercommitRatioConfig map[v1.ResourceName]string `json:"resourceOvercommitRatioConfig,omitempty"` |
There was a problem hiding this comment.
why not use a slice of custom defined structure with resource name as a field instead of map, because the scalebility of map is poor, and k8s also suggest using list instead of map https://github.com/kubernetes/kubernetes/issues/2004#issuecomment-60641437
There was a problem hiding this comment.
why not use a slice of custom defined structure with resource name as a field instead of map, because the scalebility of map is poor, and k8s also suggest using list instead of map https://github.com/kubernetes/kubernetes/issues/2004#issuecomment-60641437
thanks for the suggestion. The scalebility is pool that each resource only has a string value. I'll update it accroding to the suggestion.
There was a problem hiding this comment.
@luomingmeng I thought about it, maybe "ResourceOvercommitRatio" is more like "ResourceList" in container Resources, also we need a map to ensure the uniqueness of the resources. What do you think?
Do you have any suggestions? @caohe
There was a problem hiding this comment.
If the field is similar to ResourceList, it is better to use the name ResourceOvercommitRatio directly, rather than using ResourceOvercommitRatioConfig.
There was a problem hiding this comment.
done, ResourceOvercommitRatioConfig is renamed to ResourceOvercommitRatio.
WangZzzhe
force-pushed
the
dev/node-overcommit-config-controller
branch
from
07b4e80
to
d99092c
Compare
caohe
added
the
workflow/merge-ready
What type of PR is this?
Features
What this PR does / why we need it: