Skip to content

Commit

Permalink
Merge pull request #29 from csfldf/dev/fix_skeleton_log
Browse files Browse the repository at this point in the history
fix(skeleton): fix skeleton log not only for reporter
  • Loading branch information
waynepeking348 authored Aug 7, 2023
2 parents 9bc7309 + e6e5179 commit 7cb845b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/plugins/skeleton/generic.go
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ func (p *PluginRegistrationWrapper) start() (startError error) {
defer func() {
p.Unlock()
if startError != nil {
klog.Errorf("start %s failed with error: %v", p.Name(), startError)
// call stop to revert executed start steps for all servers
_ = p.stop()
}
Expand Down Expand Up @@ -349,7 +348,7 @@ func (p *PluginRegistrationWrapper) stop() (stopErr error) {
return fmt.Errorf("stop wrapped plugin of %s failed with err: %v", p.Name(), err)
}

klog.Infof("stop reporter plugin %s successfully", p.Name())
klog.Infof("stop plugin %s successfully", p.Name())

return nil
}
Expand Down

0 comments on commit 7cb845b

Please sign in to comment.