-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add otlp endpoint config and cli flag #994
feat: add otlp endpoint config and cli flag #994
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
==========================================
- Coverage 62.71% 62.64% -0.08%
==========================================
Files 17 17
Lines 1046 1052 +6
==========================================
+ Hits 656 659 +3
- Misses 390 393 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we really want a CLI flag for this, I think we do not need it. The rust library does check the environment variable for us.
I would add a CLI flag to define the certificate now instead. ;)
@jvanz I think we should keep both the CLI flag and the config entry. It’s better to have consistent configurations, and exposing the certificate path only through the CLI could be confusing. Having the config struct map the otlp CLI values also makes integration tests easier. |
Signed-off-by: Fabrizio Sestito <[email protected]>
… configuration Signed-off-by: Fabrizio Sestito <[email protected]>
896e93d
to
5b843fb
Compare
Fair enough. I'm fine with that. I was mentioning that just to ensure that you're aware of this possibility. ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds a new
--otlp-endpoint
flag and theOTEL_EXPORTER_OTLP_ENDPOINT
environment variable, allowing users to specify a custom gRPC OTLP endpoint for exporting both metrics and traces.Part of #993
Test
Updates existing integration tests.