fix(ci): do not sign with no real chart update. #576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign Helm chart only if the Helm chart has changed. If the chart version is already released, skip the signing step and the provenance file generation. Signed-off-by: José Guilherme Vanz <[email protected]>
viccuad
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Approving, I would like this merged as I think this is a good stop-gap solution that blocks every commit in main from creating bogus unused entries in the helm index.yaml.
It is not perfect, as GH releases are mutable and an attacker could delete/edit the release, making us skip the signing, pushing, and provenance, and then reinstate it, which is a problem for SLSA lvl3. Hence I look forward to a workflow that uses the artifacts created in it to discern if there's need to push or not.
|
I'm closing this in favor of a future PR fixing the chart releaser calls as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sign Helm chart only if the Helm chart has changed. If the chart version is already released, skip the signing step and the provenance file generation.
Related to #574