chore: Update tracing & metrics #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
✅ Deploy Preview for silly-bunny-8cedd0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jhkrug
requested changes
Jul 25, 2024
There was a problem hiding this comment.
A minor change and I think some additional backticks crept in, looking at the preview:
https://deploy-preview-431--silly-bunny-8cedd0.netlify.app/next/howtos/telemetry/metrics-qs
|
|
||
| ````yaml | ||
| --- | ||
| prometheus: |
There was a problem hiding this comment.
isn't this redundant with the two ServiceMonitor resources created below? why this change?
There was a problem hiding this comment.
Indeed, dropped them in 95ad718.
Co-authored-by: John Krug <[email protected]> Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
fabriziosestito
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the tracing and metrics how-tos so they are easier to apply.
Test
Tested by following the docs. Tracing and Prometheus seem to work Grafana doesn't. But maybe I misconfigured the
kube-prometheus-stack-values.yamland that's why I'm not receiveing enough metrics for Grafana.Additional Information
Tradeoff
Potential improvement
Feel free to edit the commits as needed.