feat: Add CI & CD #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
TODO: fossa needs `secrets.FOSSA_API_TOKEN`. openssf needs adding the labels to readme after first job run. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
distroless/static gives us only: - no libc (fine, we static-compile) - ca-certificates - A /etc/passwd entry for a root user (which we don't use) - A /tmp directory - tzdata See: https://github.com/GoogleContainerTools/distroless/blob/main/base/README.md We could also go with scratch. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Do it by using a reusable workflow for the container build. Lifted from kubewarden-controller. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
jvanz
approved these changes
Dec 16, 2022
Change `area/dependencies` to trigger patch releases instead of minor ones. Signed-off-by: Flavio Castelli <[email protected]>
|
Looking at the TODOs:
I think we have nothing to do in that regard. The fossa token is a secret shared with all the GH workers of our organization.
I've created #9 to keep track of that
This isn't clear to me, I found only Lines 51 to 55 in 7f416af Can you file an issue that provides more context please? |
|
on the linters removal before release, it's just the block that you pointed at, so I would be ok without an issue. We should grep for TODOs before release anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #5
Test
Yes please.
Additional Information
At the end, ended up lifting the approach from kubewarden-controller, with renaming.
Successful container build job run in my fork, https://github.com/viccuad/audit-scanner/pkgs/container/audit-scanner.
release-drafter needs its config in main prior to working.
Tradeoff
Potential improvement
TODO:
secrets.FOSSA_API_TOKEN